Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] web_widget_x2many_2d_matrix #1101

Merged
merged 58 commits into from
Nov 20, 2018

Conversation

alexey-pelykh
Copy link
Contributor

No description provided.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 9, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 9, 2018
40 tasks
@pedrobaeza
Copy link
Member

You should take into account opened PR for v11 #1014 + a current issue, which is #1084

@alexey-pelykh
Copy link
Contributor Author

Thanks for mentioning, I've subscribed to those to keep track of them. Any other special actions to take?

@pedrobaeza
Copy link
Member

Well, I have always missed an example embedded in this module as demo data, but it seems there's no good model for applying the 2d matrix without extra code.

@alexey-pelykh alexey-pelykh force-pushed the 12.0-mig-web_widget_x2many_2d_matrix branch from 0beaecd to bfa4dbb Compare November 9, 2018 16:55
@alexey-pelykh
Copy link
Contributor Author

@pedrobaeza #1014 taken into account

@pedrobaeza
Copy link
Member

There were a syntax error fixed here: 899f01f

@alexey-pelykh alexey-pelykh force-pushed the 12.0-mig-web_widget_x2many_2d_matrix branch from bfa4dbb to fa2969a Compare November 9, 2018 17:39
@alexey-pelykh
Copy link
Contributor Author

Cherry-picked 899f01f

@alexey-pelykh
Copy link
Contributor Author

@tarteo @yajo @jbeficent would like to ask for your review, if you don't mind

column totals. True by default

Example
=======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ~~~~~~~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@yajo yajo merged commit 95b01b2 into OCA:12.0 Nov 20, 2018
@pedrobaeza
Copy link
Member

@yajo the README will give error due to bad underlining, so you shouldn't merge without fixing that.

@alexey-pelykh
Copy link
Contributor Author

Since it was merged, what should I do?

@alexey-pelykh
Copy link
Contributor Author

(readme generator didn't error on my side for some reason)

@yajo
Copy link
Member

yajo commented Nov 20, 2018

The syntax it produced is not exactly wrong syntax, so it shouldn't error.

@alexey-pelykh You can PR again to fix it.

@alexey-pelykh alexey-pelykh deleted the 12.0-mig-web_widget_x2many_2d_matrix branch November 20, 2018 08:44
@alexey-pelykh
Copy link
Contributor Author

@yajo @pedrobaeza #1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.